feat: register AuthzNotReadOnly policy type in node-type-registry#986
Merged
pyramation merged 1 commit intomainfrom Apr 16, 2026
Merged
feat: register AuthzNotReadOnly policy type in node-type-registry#986pyramation merged 1 commit intomainfrom
pyramation merged 1 commit intomainfrom
Conversation
Adds the AuthzNotReadOnly policy type definition to the node-type-registry, matching the SQL-level implementation merged in constructive-db PR #814. - New authz-not-read-only.ts definition with entity_field + membership_type params - Exported from authz/index.ts - Regenerated blueprint-types.generated.ts (AuthzNotReadOnlyParams interface, BlueprintPolicy.$type union, BlueprintNodeObject union, BlueprintNodeShorthand)
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registers the new
AuthzNotReadOnlypolicy type in the node-type-registry, matching the SQL-level implementation merged in constructive-db#814.Hand-written changes (2 files):
authz-not-read-only.tsdefinition withentity_field(required) andmembership_type(optional) parametersauthz/index.tsAuto-generated (1 file):
blueprint-types.generated.tsregenerated viapnpm generate:types— addsAuthzNotReadOnlyParamsinterface, and includes"AuthzNotReadOnly"in theBlueprintPolicy.$typeunion,BlueprintNodeShorthand, andBlueprintNodeObjectdiscriminated union.Review & Testing Checklist for Human
blueprint-types.generated.tsdiff includes changes beyondAuthzNotReadOnly(newentity_typefields onAuthzMembershipParams,AuthzEntityMembershipParams,AuthzRelatedEntityMembershipParams,AuthzPeerOwnershipParams,AuthzRelatedPeerOwnershipParams, andmembership_typebecoming optional onAuthzMembershipParams). Confirm these match the current source definitions on main and are not regressions.entity_fieldand optionally acceptsmembership_type. Confirm this matches theAuthzNotReadOnlyhandler registered inrls_parser.parse()andast_helpers.build_policy_ast()in constructive-db.Notes
membership_typedescription says "Must be >= 2" but this is documentation only — no JSON Schemaminimumconstraint. The SQL layer enforces this via the Step 7b injection logic (only fires formembership_type >= 2).Link to Devin session: https://app.devin.ai/sessions/5b846ad23d754cbe903fa86b27c109b4
Requested by: @pyramation